Code review comment for lp:~adiroiban/launchpad/bug-359180

Revision history for this message
Aaron Bentley (abentley) wrote :

This looks mostly good. Please rename tabindex_chain to something else (we discussed "translations_order") since it doesn't affect tabbing.

The current interaction of autofocus_html_id and Y.lp.pofile.initializeKeyBindings means that javascript errors will happen if no autofocus_html_id is present. Please fix this (e.g. by addding empty variables, as you suggested).

review: Needs Fixing (code)

« Back to merge proposal