Code review comment for lp:~adiroiban/launchpad/bug-406477
Revision history for this message
| Adi Roiban (adiroiban) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
= Bug 406477 =
Members of the ubuntu-
However, once a template has been disabled, the +admin page is no longer accessible to them, which stops them from e.g. enabling the template again in case of a mistake.
== Implementation details ==
After asking a pre-implementation review from Danilo, he suggest I should use launchpad.
The previous administration privileges for IPOTemplate was assigned only to RosettaAdmins.
Now it was change to all RosettaAdmin + owner of distro.
== Tests ==
There were no test covering the use case of distribution translations coordinator admin rights to templates, so this was added to distroseries-
Also the previous rosetta-
./bin/test -ct "distroseries-
./bin/test -ct "rosetta-
== Demo and Q/A ==
Make sure you are a member of Ubuntu Translation Coordinators team (ubuntu-
https:/
Go to the Distro +template page
https:/
You should see the Administer page for Evolution, disabled-template .
As a member of Ubuntu Translation Coordinators team you should be able to administer it, just like any other template from that table.
Login as a normal user, you should not see the administration links (only Download), and when trying to manually enter the admin url (https:/
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files:
lib/canonical
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/