Code review comment for lp:~adiroiban/launchpad/bug-406477

Revision history for this message
Adi Roiban (adiroiban) wrote :

Hi,

Thank you very much for taking the time and reviewing this branch.
It was really ugly. So don't worry, I deserve it :)

I agree that is hard to cover all test paths, is just that right now I don't know what should be tested and what not, and where is the border between a useful test and a bloated test.
Is a test is not needed, feel free to comment and I will delete it.

I'm testing using a single command line, but in MP I put them in different lines to improve readability... stupid thing to do :). For the future I'll put them in a single line.

Disabled templates are only displayed for TranslationsAdmins.
The previous behavior was validated by test stories.

I didn't knew Ubuntu is already a celebrity.
I prefer to keep with Ubuntu, without creating a new distribution. It will just make the story to complicated.
Added a "license=yes" to MakeTranslator , to also sign the translation license.. otherwise that translator has no edit rights.

I'm sorry for failing to write proper stories. Hope I can improve my narrator skills.

Hope the permission are right.

I added stories for testing administration and editing of POTemplate and PoTemplateSubset.

Thank you again for taking the time reviewing this branch.
If there are further issues, have no mercy! :)

It is ok to have these filenames?
xx-potemplate-admin.txt
xx-potemplate-edit.txt
xx-rosetta-potemplate-export.txt
xx-rosetta-potemplate-index.txt

I was thinking at removing rosetta from the filename.

« Back to merge proposal