Code review comment for lp:~adiroiban/launchpad/bug-427319

Hi Salgado,

The failing test is /home/adi/launchpad/lp-branches/bug-427319/lib/lp/translations/browser/tests/test_distroserieslanguage_views.py, line 51, in test_translation_group

    def test_translation_group(self):
        group = self.factory.makeTranslationGroup(
            self.distroseries.distribution.owner, url=None)
        self.distroseries.distribution.translationgroup = group
        self.assertEquals(self.view.translation_group, group)

I tried to change it to the following code... but with no luck

    def test_translation_group(self):
        group = self.factory.makeTranslationGroup(
            self.distroseries.distribution.owner, url=None)
        self.distroseries.distribution.translationgroup = group
        self.view = DistroSeriesLanguageView(
            self.dsl, LaunchpadTestRequest())
        self.assertEquals(self.view.translation_group, group)

--------------------
This is a fix for the view, but maybe I have to fix the test.

=== modified file 'lib/lp/translations/browser/serieslanguage.py'
--- lib/lp/translations/browser/serieslanguage.py 2009-12-12 07:16:07 +0000
+++ lib/lp/translations/browser/serieslanguage.py 2009-12-15 02:25:54 +0000
@@ -38,11 +38,9 @@
     label = "Translatable templates"
     series = None
     parent = None
- translationgroup = None

     def initialize(self, series, translationgroup):
         self.series = series
- self.translationgroup = translationgroup
         self.form = self.request.form

         self.batchnav = BatchNavigator(
@@ -58,7 +56,10 @@

         Return None if there's no translation group for them.
         """
- return self.translationgroup
+ if (self.context.distroseries):
+ return self.context.distroseries.distribution.translationgroup
+ else:
+ return self.context.productseries.product.translationgroup

     @cachedproperty
     def translation_team(self):
@@ -134,25 +135,21 @@
             "translations.")

-class DistroSeriesLanguageView(BaseSeriesLanguageView, LaunchpadView):
+class DistroSeriesLanguageView(BaseSeriesLanguageView):
     """View class to render translation status for an `IDistroSeries`."""

     def initialize(self):
- series = self.context.distroseries
         super(DistroSeriesLanguageView, self).initialize(
- series=series,
- translationgroup=series.distribution.translationgroup)
+ series=self.context.distroseries)
         self.parent = self.series.distribution

-class ProductSeriesLanguageView(BaseSeriesLanguageView, LaunchpadView):
+class ProductSeriesLanguageView(BaseSeriesLanguageView):
     """View class to render translation status for an `IProductSeries`."""

     def initialize(self):
- series = self.context.productseries
         super(ProductSeriesLanguageView, self).initialize(
- series=series,
- translationgroup=series.product.translationgroup)
+ series=self.context.productseries)
         self.context.recalculateCounts()
         self.parent = self.series.product