Code review comment for lp:~adiroiban/launchpad/bug-431249

= Bug 431249 =

The templates pofile-translate.pt and translationmessage-translate.pt share the same set of navigation links so they should be factored out into their own macro file to be used by both.

== Proposed fix ==

A general +translations-macros view was creating for hosting translations macros.
The macro page hosting a single macro for translationmessage-translate.pt was renamed to a generic name.
The required pages were updated to the new macro path.

The macro required to fix this bug is hosted by translations-macros.pt

== Tests ==
I have added the required test in the required stories.

./bin/test -ct "translationmessage-translate" -t "pofile-translate"

Note: these tests are using the old formating style, but I left those change to have a clean diff.
If everthing is OK, after the review I can update the formating

== Demo and Q/A ==

For PO file go to this link:
http://translations.launchpad.dev/ubuntu/hoary/+source/evolution/+pots/evolution-2.2/es/+translate

For translation message go to this link:
http://translations.launchpad.dev/ubuntu/hoary/+source/evolution/+pots/evolution-2.2/es/5

As an anonymous user or a user with no right for changing the translations you should only see the links to Download translation and Translation details

Translation admin / reviewer also have access to the upload page and they will see all links: Download translation, Upload translation and Translation details

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/translations/browser/configure.zcml
  lib/lp/translations/stories/standalone/xx-pofile-translate.txt
  lib/lp/translations/stories/standalone/xx-translationmessage-translate.txt
  lib/lp/translations/templates/currenttranslationmessage-translate-one.pt
  lib/lp/translations/templates/pofile-translate.pt
  lib/lp/translations/templates/translationmessage-suggestions.pt
  lib/lp/translations/templates/translationmessage-translate.pt
  lib/lp/translations/templates/translations-macros.pt