Merge lp:~adiroiban/launchpad/bug-492375 into lp:launchpad

= Bug 492375 =
Suppose I want to translate Ubuntu into Romanian.
I will go to: https://translations.edge.launchpad.net/ and click on "Ubuntu Karmic (9.10)"
The next page will be :
https://translations.edge.launchpad.net/ubuntu/karmic/+translations
Then I have to scroll all along the page and search for Romanian in that big and compact list.

== Proposed fix ==
At first page load, only display users preferred languages and display a link for viewing all languages.

Just like we do for source packages:
https://translations.launchpad.net/ubuntu/karmic/+source/gfxboot-theme-ubuntu/

== Pre-implementation notes ==

After a long chat with Danilo and Jeroen we decided it is best to put the class selection login in the template with some help from the view.

== Tests ==

bin/test --layer=TranslationsWindmillLayer -D -t serieslanguages

UI Review screenshots:
 * http://launchpadlibrarian.net/36485928/preferred.png
 * http://launchpadlibrarian.net/36485936/all-languages.png

== Demo and Q/A ==

Access one of the page presenting language series.
For example http://translations.launchpad.dev/ubuntu

If you are not logged in, you will see a list of languages obtained using geoip.
You can click the "View all languages" and the table should display all langauges for Ubuntu.

If you are logged in, it will show only your preferred languages.

Adi Roiban wrote:
> Adi Roiban has proposed merging lp:~adiroiban/launchpad/bug-492375
> into lp:launchpad/devel.
>
> Requested reviews:
> Canonical Launchpad Engineering (launchpad)
> Related bugs:
> #492375 At first, display only translations statistics for preferred
> languages
> https://bugs.launchpad.net/bugs/492375
Hello Adi,

thank you very much for preparing this branch which generally looks
very good. Please see my comments below for more detail.

[..]

> == Tests ==
>
> bin/test --layer=TranslationsWindmillLayer -D -t serieslanguages
All tests pass except for the one "that always fails" as discussed on IRC:
{{{
<adiroiban> al-maisan: ah... that is part of user.ensure_login(self.client)
<adiroiban> and it fails for all windmill tests
}}}

> == Demo and Q/A ==
>
> Access one of the page presenting language series.
> For example http://translations.launchpad.dev/ubuntu
>
> If you are not logged in, you will see a list of languages obtained
> using geoip.
> You can click the "View all languages" and the table should display
> all langauges for Ubuntu.
>
> If you are logged in, it will show only your preferred languages.
This works as described.

> === modified file 'lib/canonical/launchpad/javascript/translations/translations.js'
> --- lib/canonical/launchpad/javascript/translations/translations.js 2009-11-24 09:30:01 +0000
> +++ lib/canonical/launchpad/javascript/translations/translations.js 2009-12-17 14:38:47 +0000
> @@ -116,7 +116,7 @@
> * which is defined in a code fragment that is included in the page via TAL.
> */
> var init_status_choice = function(content_box, index, list) {
> - content_box.setStyle('display', '')
> + content_box.setStyle('display', '');
> var conf = choice_confs[index];
> conf.title = 'Change status to';
> conf.contentBox = content_box;
> @@ -165,6 +165,11 @@
> button_markers.on('click', show_output);
> };
>
> +var toggle_node_visibility = function(node, index, list) {
> + node.toggleClass('unseen');
> + node.toggleClass('seen');
> +};
> +
> /**
> * Set up the import queue page.
> */
> @@ -183,6 +188,37 @@
> spinner_loader.set('innerHTML', '');
> };
>
> +
> +/**
> + * Set up initial the visibility for languages in a serieslanguages table.
"Set up the initial visibility.." ?

> + */
> +translations.initialize_languages_table = function(Y) {
> + Y.all('.not-preferred-language').each(function(node, index, list) {
> + node.addClass('unseen');
> + });
> + Y.all('.preferred-language').each(function(node, index, list) {
> + node.addClass('seen');
> + });
> +};
> +
> +
> +/**
> + * Toggle visibility for languages in a serieslanguages table.
> + */
> +translations.toggle_languages_visibility = function(e) {
> + e.preventDefault();
> + Y.all('.not-preferred-language').each(toggle_node_visibility);
> + var toggle_button = e.currentTarget;
> + if (toggle_button.hasClass('all-languages-visible')) {
> + toggle_button.setContent('View All Languages');
> + toggle_button.removeClass('all-languages-visible');
> + } else {
> + toggle_button.setContent('View Only Preferred Languages');
> + toggle_button...

Looks good, thanks Adi!

Hi Adi, this is great!

I'm really glad you all agreed on the JS version - it's great being able to switch between preferred and all languages without a page-load.

I've only got two thoughts regarding things that were not actually changed by your branch:

First, the capitalization of the "Choose preferred languages - View all languages" links (only first word capitalized, as outlined here: https://dev.launchpad.net/UserInterfaceWording#Capitalization

(Just for reference, there are a bunch of useful links for stuff like that at https://dev.launchpad.net/UI/Reviews)

Second, it's a little bit strange that if my preferred language is just "English", then all languages are displayed, but I still see the 'View all languages'/'View preferred languages'. If this is expected that all languages are displayed when a persons preferred language is "English", then I think we should hide the toggle link in that case?

What do you think?