Code review comment for lp:~adiroiban/launchpad/bug-492375

Revision history for this message
Michael Nelson (michael.nelson) wrote :

Hi Adi, this is great!

I'm really glad you all agreed on the JS version - it's great being able to switch between preferred and all languages without a page-load.

I've only got two thoughts regarding things that were not actually changed by your branch:

First, the capitalization of the "Choose preferred languages - View all languages" links (only first word capitalized, as outlined here: https://dev.launchpad.net/UserInterfaceWording#Capitalization

(Just for reference, there are a bunch of useful links for stuff like that at https://dev.launchpad.net/UI/Reviews)

Second, it's a little bit strange that if my preferred language is just "English", then all languages are displayed, but I still see the 'View all languages'/'View preferred languages'. If this is expected that all languages are displayed when a persons preferred language is "English", then I think we should hide the toggle link in that case?

What do you think?

review: Approve (ui)

« Back to merge proposal