Code review comment for lp:~adiroiban/launchpad/bug-509252-take-2

Revision history for this message
Henning Eggers (henninge) wrote :

Hi Adi,
sorry for not replying but I had expected that you push an updated branch with whatever changes you see possible.

I did not know that metal tags are being used to raise exceptions and I am pretty sure that should not be that way. If you think it's too much work to improve that in this branch, I can understand that. Please file a bug so that it gets done at some later time.

So, a new push to the branch would be the next thing to get the review forward.

Cheers,
Henning

« Back to merge proposal