Code review comment for lp:~adiroiban/launchpad/bug-509252-take-2

Revision history for this message
Henning Eggers (henninge) wrote :

Thanks, this looks much better. Unfortunately the diff shows conflicts, so I guess you need to merge devel and push again for the diff to be correct.

Also, is there no unit test that could go through all the different SeriesStatus values? Doing this in a doc test looks like it's in the wrong place. But please only do this if it is fairly easy. I think this branch is already old enough ... ;-)

« Back to merge proposal