Code review comment for lp:~adiroiban/launchpad/bug-509252

= Bug 509252=
After landing this branch https://code.edge.launchpad.net/~adiroiban/launchpad/bug-340662-take-2/+merge/17598
the POTemplateSubsetNavigation will render the AdminPOTemplateSubset useless.

We should clean the security.py.

AdminPOTemplateSubset was added to fix bug 406477

== Proposed fix ==
Remove AdminPOTemplateSubset from security.py since it is no longer used.

== Pre-implementation notes ==

The changes in POTemplateSubsetNavigation were done before the release for another branch/bug that was important to land.

This should be a simple task, but since we did not want to risk and did not have enough time, Danilo and I, agreed to look into removing this class after the release.

== Implementation details ==
== Tests ==
These are the tests for bug 406477 (where the class was added)

lp-test -t distroseries-templates -t rosetta-potemplate-index

== Demo and Q/A ==
This is the demo from bug 406477

Make sure you are a member of Ubuntu Translation Coordinators team (ubuntu-l10n-coordinator).
https://launchpad.dev/~ubuntu-l10n-coordinator

Go to the Distro +template page
https://translations.launchpad.dev/ubuntu/hoary/+templates

You should see the Administer page for Evolution, disabled-template .

As a member of Ubuntu Translation Coordinators team you should be able to administer it, just like any other template from that table, even if the template is now disabled.

Login as a normal user, you should not see the administration links (only Download), and when trying to manually enter the admin url (https://translations.launchpad.dev/ubuntu/hoary/+source/evolution/+pots/disabled-template/+admin) you should see an access denied page.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/canonical/launchpad/security.py