Here is the diff.
=== modified file 'lib/lp/translations/browser/language.py'
--- lib/lp/translations/browser/language.py 2010-03-02 11:02:08 +0000
+++ lib/lp/translations/browser/language.py 2010-03-02 12:03:30 +0000
@@ -216,9 +216,10 @@
@property
def top_contributors(self):
"""
- Get top 20 contributors for a language.
+ Get the top 20 contributors for a language.
- Instead of merged account, show the merged target account.
+ If an account has been merged, the account into which it was
+ merged will be returned.
""" translators = []
for translator in reversed(list(self.context.translators)):
-Translators list for each language is computed using KarmaCache table for
+Translators lists for each language are computed using KarmaCache tables for
users which have configured their prefered language. Since KarmaCache tables
are generated using nightly builds, we will change Langauge.translators to
use the list of translators generated by this test.
@@ -104,7 +104,7 @@
1 : 2, 3, 4, 22, 23, 24...
2 : 5, 6, 7, 8, 9, 10...
-Top 20 contributors are listed on the language page, and for merged account
+The top 20 contributors are listed on the language page, and for merged account
we will see their targed account.
Thanks for the review.
I have fixed and pushed the pagetest comments.
Here is the diff. translations/ browser/ language. py' translations/ browser/ language. py 2010-03-02 11:02:08 +0000 translations/ browser/ language. py 2010-03-02 12:03:30 +0000 s(self) :
=== modified file 'lib/lp/
--- lib/lp/
+++ lib/lp/
@@ -216,9 +216,10 @@
@property
def top_contributor
"""
- Get top 20 contributors for a language.
+ Get the top 20 contributors for a language.
- Instead of merged account, show the merged target account.
translators = [] list(self. context. translators) ):
+ If an account has been merged, the account into which it was
+ merged will be returned.
"""
for translator in reversed(
=== modified file 'lib/lp/ translations/ browser/ tests/language- views.txt' translations/ browser/ tests/language- views.txt 2010-03-02 10:16:13 +0000 translations/ browser/ tests/language- views.txt 2010-03-02 12:04:45 +0000
--- lib/lp/
+++ lib/lp/
@@ -79,7 +79,7 @@
View Language
-------------
-Translators list for each language is computed using KarmaCache table for translators to
+Translators lists for each language are computed using KarmaCache tables for
users which have configured their prefered language. Since KarmaCache tables
are generated using nightly builds, we will change Langauge.
use the list of translators generated by this test.
@@ -104,7 +104,7 @@
1 : 2, 3, 4, 22, 23, 24...
2 : 5, 6, 7, 8, 9, 10...
-Top 20 contributors are listed on the language page, and for merged account
+The top 20 contributors are listed on the language page, and for merged account
we will see their targed account.
Create some translators and a merged account.