Code review comment for lp:~adiroiban/launchpad/bug-525371

Hi Adi,

It's really great that you're doing this. I'm reading it through and it looks good to me so far. One note though about the testing in xx-distroseries.txt.

You've got the problem here that you have to rely on existing test data, which can be a bit arbitrary. For example, the fact that there are 6 templates in the distroseries is pretty meaningless in the context of the test. But it's a lot of trouble to set up a fresh distroseries with fresh translation templates, especially if the existing tests don't do it either.

So here's an idea: instead of printing the exact number of templates, why not show that int(all_translation_templates['total_size']) is identical to len(list(getUtility(ILaunchpadCelebrities).ubuntu.getSeries('hoary'))).

Jeroen