Code review comment for lp:~adiroiban/launchpad/bug-531261

Revision history for this message
Adi Roiban (adiroiban) wrote :

> Hi Adi,
>
> This is a nice refactoring; thanks for doing it.
>
> There's just one thing I noticed which was not mentioned in your cover
> letter: the IProductSeries interface has grown a 'active' attribute,
> thanks to ISeriesMixin. Since your branch doesn't add any code that
> uses that attribute, I don't see a reason for adding it, so I'd suggest
> moving it to IDistroSeries and the actual implementation to
> DistroSeries. Unless you do plan to use IProductSeries.active
> somewhere?
>
In the current code from lp/devel 'active' is the only attribute of ISeriesMixin. I was thinking it was put there to be used in the future.

« Back to merge proposal