Code review comment for lp:~adiroiban/launchpad/bug-531261

On Mon, 2010-03-08 at 10:13 +0000, Adi Roiban wrote:
> This is a small diff that fixes a spurious test, as a few line below the test is using both display_name and name:
>
> >>> for project in project_entries[:5]:
> ... print "%s (%s)" % (project['display_name'], project['name'])
> APTonCD (aptoncd)
> Arch mirrors (arch-mirrors)
> Bazaar (bazaar)
> Bazaar (bzr)
> Derby (derby)
>
> === modified file 'lib/lp/registry/stories/webservice/xx-project-registry.txt'
> --- lib/lp/registry/stories/webservice/xx-project-registry.txt 2010-03-08 09:34:22 +0000
> +++ lib/lp/registry/stories/webservice/xx-project-registry.txt 2010-03-08 10:07:31 +0000
> @@ -500,7 +500,7 @@
> >>> project_collection = webservice.get("/projects?ws.size=75").jsonBody()
>
> >>> project_entries = sorted(
> - ... project_collection['entries'], key=itemgetter('display_name'))
> + ... project_collection['entries'], key=itemgetter('display_name','name'))

This line has more than 80 chars now, no? Can you break it between the
two args?

 review approve

--
Guilherme Salgado <email address hidden>