Code review comment for lp:~adiroiban/launchpad/bug-532239

Revision history for this message
Robert Collins (lifeless) wrote :

I have a few open questions here.

Firstly, we use the XMLRPC server from live servers. Will this / can this cause the existing users to handle errors wrongly (I think it can). If so, we'll have to do special rollouts for this change, which is a pain. Please consider how to avoid that (e.g. by landing a fix to the clients in advance of this change, in particular the fix would need to be CP'd in advance).

Secondly, you seem to be reducing the clarity of raised errors, and I don't see that as being an improvement. (By dropping the context that the missing thing is missing in).

review: Needs Information

« Back to merge proposal