Code review comment for lp:~adiroiban/launchpad/bug-97293

Revision history for this message
Adi Roiban (adiroiban) wrote :

= Bug 97293 =
== Proposed fix ==
When you click the Copy text icon for plural form, beside filling the required fields, the corresponding radiobuttons are also selected

== Implementation details ==

In the same JS function that copies the plural data, the corresponding radiobuttons state is changed.

== Demo and Q/A ==

Log in as admin (so that you will have edit rights) and go to evolution translations in Ubuntu

https://translations.launchpad.dev/ubuntu/hoary/+source/evolution/+pots/evolution-2.2/ro/16/+translate

Click Copy text icon after "English plural:" .

The english plural value should be copied in all Romanian plural fields and they should be also selected.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/canonical/launchpad/javascript/lp/lp.js

== JSLint notices ==
No handlers could be found for logger "bzr"
jslint: Lint found in '/home/adi/launchpad/lp-branches/bug-97293/lib/canonical/launchpad/javascript/lp/lp.js':
Line 529 character 18: Be careful when making functions within a loop. Consider putting the function in a closure.
                });

jslint: 1 file to lint.

« Back to merge proposal