Code review comment for lp:~ahayzen/qtubuntu-print/empty-branch-for-bileto

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Packaging review:

debian/copyright
  * GPL-3.0+ should really be GPL-3.0. However this is a library so I think LGPL is probably more suitable than GPL, but I'm not a lawyer.
  * If the license and the copyright is the same, you don't need the Files: debian/* section at all.
  * Remove the comments at the bottom, that was meant to be template documentation
  * You need to include a copy of the license with the source, copy the correct license file to COPYING in the root of the project

debian/rules:
  * Please remove any unused code in the file

You need to use split mode to get the sources properly, please add the following file to the project. Look at content-hub for an example:
cat .bzr-builddeb/default.conf
[BUILDDEB]
split = True

review: Needs Fixing (packaging)

« Back to merge proposal