Launchpad itself

Code review comment for lp:~al-maisan/launchpad/ejdt-n-1

  1. ejdt-n-1
  2. Merge into devel
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

We went through a lot of improvements together: polishing up names, using COALESCE() to make the SQL more succinct, breaking up unit tests more finely, moving bits of code about. The last change I saw is that you replaced the endless repeated processor lookups with attributes on the test case. The result looks good to me.

Thanks for doing this work!

review: Approve (code)

« Back to merge proposal