Code review comment for lp:~al-maisan/launchpad/partner-expiry-535030

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Looks good.

We discussed a few minor changes in IRC:

 * Use a dict for parameter substitution in those big queries; less brittle as the code continues to evolve.

 * Use the "common tests" class as a mixin rather than a fully-functional base class. That way you don't need to tell the test loader not to run it on its own.

Jeroen

review: Approve (code)

« Back to merge proposal