Code review comment for lp:~al-maisan/launchpad/sync-470411

Revision history for this message
Muharem Hrnjadovic (al-maisan) wrote :

This change was requested by the distro team:

{{{
<slangasek> kirkland, james_w`, jdstrand, al-maisan, StevenK: until bug #470411 is addressed, sync-source.py -a will pull from the wrong Debian suite by default, so please take care when autosyncing
<bugbot> Launchpad bug 470411 in soyuz "please change the default source suite for Debian to 'testing' in _syncorigins.py" [Undecided,New] https://launchpad.net/bugs/470411
* al-maisan gets going on the bug above ..
<slangasek> al-maisan: ok, cheers :)
<al-maisan> so, here's the change for bug #470411:
<al-maisan> === modified file 'scripts/ftpmaster-tools/_syncorigins.py'
<al-maisan> --- scripts/ftpmaster-tools/_syncorigins.py 2009-07-23 02:33:14 +0000
<al-maisan> +++ scripts/ftpmaster-tools/_syncorigins.py 2009-11-02 12:27:28 +0000
<al-maisan> @@ -12,7 +12,7 @@
<al-maisan> "debian": {
<al-maisan> "name": "Debian",
<al-maisan> "url": "http://ftp.debian.org/debian/",
<al-maisan> - "default suite": "unstable",
<al-maisan> + "default suite": "testing",
<al-maisan> "default component": "main",
<al-maisan> "dsc": "must be signed and valid"
<al-maisan> },
<bugbot> Launchpad bug 470411 in soyuz "please change the default source suite for Debian to 'testing' in _syncorigins.py" [High,Triaged] https://launchpad.net/bugs/470411
<al-maisan> Is that all that's needed?
* njpatel is now known as njpatel|lunch
<al-maisan> cjwatson: ^^
<cjwatson> al-maisan: sounds right
<al-maisan> cjwatson: thanks.
<cjwatson> al-maisan: will it be easy to revert this for lucid+1?
<cjwatson> (this is why syncorigins.py should be controlled by platform, not in the launchpad source, but hey ...)
<al-maisan> cjwatson: it's a 1-line change again
<cjwatson> right, just a matter of timing
<al-maisan> yup
<cjwatson> we'll need it applied on production in roughly the four-day window following the lucid release
}}}

« Back to merge proposal