Code review comment for lp:~al-maisan/launchpad/unembargo-443075

Revision history for this message
Abel Deuring (adeuring) wrote :

Sorry, forgot another nitpick:

> > + self.assertEquals(body,
> > + 'foocomm (1.0-2) breezy; urgency=low\n\n'
> > + ' * Initial version\n\n'
> > + 'Date: Thu, 16 Feb 2006 15:34:09 +0000\n'
> > + 'Changed-By: Foo Bar <email address hidden>\n'
> > + 'Maintainer: Launchpad team <email address hidden>\n'
> > + 'http://launchpad.dev/ubuntutest/breezy-
> autotest/+source/foocomm/1.0-2\n')

IIRC, we agreed in a reviewer meeting a month ago or so to use
the expected value as the first parameter. So, could you move "body" a bit down?

« Back to merge proposal