Code review comment for lp:~alecu/ubuntuone-client/add-simple-zeitgeist

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Tests will not run due to:

== Python Lint Notices ==

./tests/eventlog/test_zglog.py:
    94: undefined name 'NotFoundError'

* Please remove spaces from docstring and add ending dot and initial upper case for:

""" Tests module """
""" event logging module """

* Is this correct? stdout has an extra -

121 + tempstdout = tempfile.TemporaryFile(prefix="test-u1-stdout-")
122 + tempstderr = tempfile.TemporaryFile(prefix="test-u1-stderr")

* This code:

233 + except RuntimeError, e:
234 + print e

should use the ubuntuone.logger and log the exception

review: Needs Fixing

« Back to merge proposal