Code review comment for lp:~alecu/ubuntuone-client/add-simple-zeitgeist

Revision history for this message
Alejandro J. Cura (alecu) wrote :

> > Could you change the strings in zlog.py from "blah""" to just "blah"? I
> didn't
> > even know the former was valid python, and it looks horrible.
>
> It works because they are interpreted as two strings: "blah" and "" (empty),
> and then they are merged into one by implicit string concatenation, since they
> are in a parenthesized context.

Yeah, we discussed about this in PyAr a while ago, and I still find that it's ugly that this is valid python:
   print "abc"""

And that this is not:
   print """abc"

I think that implicit string concatenation in python *should* mandate a space between strings, but I guess it's a bit late to change the interpreter and third part parsers, and such.

Also, I think that in this case parenthesized context does not matters.

« Back to merge proposal