Code review comment for lp:~allenap/launchpad/dont-pass-bugwatches-to-externalbugtracker

Revision history for this message
Michael Nelson (michael.nelson) wrote :

G'day Gavin,

All looks very straight forward. Just one tiny comment below.

> === modified file 'lib/lp/bugs/doc/externalbugtracker-bugzilla-api.txt'
> --- lib/lp/bugs/doc/externalbugtracker-bugzilla-api.txt 2009-12-23 10:49:55 +0000
> +++ lib/lp/bugs/doc/externalbugtracker-bugzilla-api.txt 2010-01-07 12:21:47 +0000
> @@ -406,7 +406,7 @@
> a given remote bug.
>
> >>> bugzilla.xmlrpc_transport.print_method_calls = True
> - >>> bug_comment_ids = bugzilla.getCommentIds(bug_watch)
> + >>> bug_comment_ids = bugzilla.getCommentIds(bug_watch.remotebug)
> CALLED Bug.comments({'ids': [1], 'include_fields': ['id']})
>
> >>> print sorted(bug_comment_ids)
> @@ -415,7 +415,7 @@
> getCommentIds() can only be called if initializeRemoteBugDB() has been
> called and the bug exists locally.
>
> - >>> bugzilla.getCommentIds(bug_watch_broken)
> + >>> bugzilla.getCommentIds(bug_watch_broken.remotebug)
> Traceback (most recent call last):
> ...
> BugNotFound: 42
> @@ -425,11 +425,11 @@
> ---------------
>
> ISupportsCommentImport.fetchComments() is the method used to fetch a
> -given set of comments from the remote bugtracker. It takes a bug watch
> -and a list of the comment IDs to retrieve for that bug watch.
> +given set of comments from the remote bugtracker. It takes a remote
> +bug and a list of the comment IDs to retrieve for that bug watch.

It seems everywhere else you've referred to it as a remote bug ID, which
I think is clearer (I was at first expecting it to be an object).

review: Approve (code)

« Back to merge proposal