Code review comment for lp:~allenap/launchpad/ec2-test-remote-non-ascii-issue-bug-447247

Revision history for this message
Gavin Panella (allenap) wrote :

The following diff was also needed because branch.revno() is an int, and can't be escaped directly, nor does it need to be.

=== modified file 'lib/devscripts/ec2test/ec2test-remote.py'
--- lib/devscripts/ec2test/ec2test-remote.py 2009-10-09 14:50:33 +0000
+++ lib/devscripts/ec2test/ec2test-remote.py 2009-10-09 15:04:24 +0000
@@ -339,8 +339,9 @@
                         'revno': branch.revno()}
                 write(
                     '- %(name)s\n %(branch)s\n %(revno)d\n' % data)
- escaped_data = dict(
- (key, escape(value)) for (key, value) in data.iteritems())
+ escaped_data = {'name': escape(name),
+ 'branch': escape(branch.get_parent()),
+ 'revno': branch.revno()}
                 index_file.write(textwrap.dedent('''\
                     <dt>%(name)s</dt>
                       <dd>%(branch)s</dd>

« Back to merge proposal