Code review comment for lp:~allenap/launchpad/more-retest

> This branch adjusts retest.py to allow pasting of a test report (by
> using fileinput), changes the parsing code to work with multiple
> chunks (so test output can be appended to a log), makes it *not* run
> the whole test suite if it doesn't find any tests in the log, improves
> the usage docs, and MOST IMPORTANTLY makes it possible to kill the
> test process with Ctrl-C, which was especially important in the days
> when it could decide to try and run the whole test suite.
>
> It also moves the script to be a buildout template, which ends up
> creating bin/retest (currently it's not a template, and lives in
> utilities/retest.py).

That's great! Thanks Gavin.

launchpad/more-retest/+merge/12709
<noodles775> allenap: sure thing!
<allenap> noodles775: Thanks :)
<thumper> deryck: https://code.edge.launchpad.net/~thumper/launchpad/inline-lifecycle-status-edit/+merge/12707
* sinzui (n=sinzui@91.189.88.12) has joined #launchpad-reviews
<noodles775> allenap: nice - I hadn't seen takewhile before...
<noodles775> allenap: on line 97, why are you converting to a set rather than a list?
<noodles775> I mean, test output will not have duplicates...?
* noodles775 has changed the topic to: on call: noodles775 || reviewing: allenap || queue: [] || This channel is logged: http://irclogs.ubuntu.com
<allenap> noodles775: If multiple test logs are passed in (one of the new features), this removes duplicates.
<noodles775> allenap: then why not convert it back to a sorted list then and there?
<noodles775> ie., so extract_tests returns a sorted list of unique tests?
<noodles775> That's great that multiple logs can be used - and that it's now using a buildout template!
<allenap> noodles775: I only want them sorted to display them prettily, otherwise a set is what I want. Not much in it really.
<allenap> noodles775: As in, could be either a set or a list, but it happens to be a set because of de-duplication.
<noodles775> oh, I didn't see the set features being used anywhere... looking again.
<noodles775> Ah, gotcha. ok.
* sinzui has quit (Read error: 104 (Connection reset by peer))
* sinzui1 (n=sinzui@91.189.88.12) has joined #launchpad-reviews
<noodles775> allenap: great, r=me... just note, there's one reference to the old utilities/retest in the usage instructions.
<noodles775> er, actually, two :)
<allenap> noodles775: Ah, good spot, thanks :)