Code review comment for lp:~allenap/launchpad/rocketfuel-get-overwrite

Revision history for this message
Michael Nelson (michael.nelson) wrote :

<noodles775> allenap: so your branch will result in *all* branches updated including the overwrite flag right? Are there any side-effects or dangers in doing this?
<allenap> noodles775: If someone has edited one of their sourcecode branches it will be clobbered.
<allenap> noodles775: But people - including me - shouldn't really be making a habit of that, because if I forget to revert I might get strange behaviour in other branches.
<noodles775> allenap: ah, so update_branches() is only ever called in update_sourcecode() - right.
<noodles775> Yep.
<allenap> noodles775: Yep, I think so.
<noodles775> Yep, it is (currently).

review: Approve (code)

« Back to merge proposal