Code review comment for lp:~allenap/launchpad/show-me-too-counts

Revision history for this message
Abel Deuring (adeuring) wrote :

Wow, like Michael, I am really impressed by the effort you put into proper wording for the different cases if the current user is affected or not, iand how many other users are affected!

Thanks for the additional "normalisation", as dicussed on IRC:

(18:20:33) abel: allenap: shouldn't _getNewSourceNames() also be able to deal with others_affected_count == 0?
(18:21:41) allenap: abel: In that case it returns nothing. I'll add a comment to make that clear.
(18:23:13) abel: allenap: sure, is does nothing in this case. My question is: What will be displayed in this case?
(18:23:48) abel: allenap: ahm, now I got it...
(18:23:51) allenap: abel: The source_name values at around line 1552 in the same file.
(18:24:14) abel: allenap: thanks, sorry for being a bit confused today...
(18:24:25) allenap: abel: Perhaps I should change _getNewSourceNames to _getSourceNames and do it all from there?
(18:24:56) abel: allenap: right, I was thinking roughly in this direction too. sounds good

review: Approve (code)

« Back to merge proposal