Code review comment for lp:~allenap/launchpad/twisted-threading-bug-491870

Hi Henning,

Thank you for the review. I added some more info about install_signal_handlers, and added some tests for SerialScheduler.

I also switched to using the default reactor thread pool instead of creating my own in TwistedThreadScheduler. I felt it was better to be explicit, but two things changed my mind:

 * We're calling reactor.run(). It's ours, we're not sharing it, so no harm in just using its thread pool.

 * The import fascist was complaining about importing deferToThreadPool. Maybe this should be in its module's __all__, maybe not. I'll file a bug for that.

Incremental diff: http://paste.ubuntu.com/372542/

Thanks, Gavin.