Code review comment for lp:~allenap/launchpad/ui-convert-filebug-3.0-bug-415263-search

Revision history for this message
Gavin Panella (allenap) wrote :

This converts the +filebug search page to the 3.0 layout, using the
main_only layout. This included removing the "Most frequently reported
bugs" area, which, after discussion with noodles, wgrant and beuno, is
basically not very useful, especially in comparison with the more
accurate, detailed and useful duplicate listing shown on the following
page.

Test: ./bin/test -vvt filebug

Lint free.

lib/lp/bugs/browser/bugtarget.py

  Removed the most_common_bugs and found_possible_duplicates
  properties. The first, most_common_bugs, was only used by the "Most
  frequently reported bugs" area, and found_possible_duplicates was
  already unused.

  Also, I removed a little lint.

lib/lp/bugs/doc/minimizing-duplicate-bug-reports.txt

  I also removed the IBugTarget.getMostCommonBugs() method because,
  list the most_common_bugs property above, was only used for the
  +filebug search page. This test was entirely about
  getMostCommonBugs(), so I removed it too.

lib/lp/bugs/interfaces/bugtarget.py
lib/lp/bugs/model/bugtarget.py

  getMostCommonBugs() removed.

lib/lp/bugs/stories/guided-filebug/xx-displaying-similar-bugs.txt
lib/lp/bugs/stories/guided-filebug/xx-distro-guided-filebug.txt
lib/lp/bugs/stories/guided-filebug/xx-distro-sourcepackage-guided-filebug.txt
lib/lp/bugs/stories/guided-filebug/xx-product-guided-filebug.txt

  "Most frequently reported bugs" area removed, so tests for it
  removed too.

lib/lp/bugs/templates/bugtarget-filebug-search.pt

  Template converted. The only interesting thing here was the extra
  condition around the not_uses_malone macro call. The not_uses_malone
  macro already checks the same condition, but I think that the
  condition should be checked in the calling template instead. Once
  the other templates that use the not_uses_malone macro have been
  converted to follow this style, the condition in the macro will be
  removed.

lib/lp/bugs/tests/bug.py

  The print_bugs_table() helper was only used in one place. That place
  has now gone, so the helper goes too.

lib/lp/registry/configure.zcml

  Remove getMostCommonBugs.

« Back to merge proposal