Merge lp:~allenap/lazr.restful/james_w into lp:lazr.restful

Proposed by Gavin Panella
Status: Merged
Merged at revision: not available
Proposed branch: lp:~allenap/lazr.restful/james_w
Merge into: lp:lazr.restful
Diff against target: 30 lines
2 files modified
setup.py (+1/-1)
src/lazr/restful/example/base/tests/field.txt (+6/-3)
To merge this branch: bzr merge lp:~allenap/lazr.restful/james_w
Reviewer Review Type Date Requested Status
Guilherme Salgado (community) Approve
Review via email: mp+12414@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Gavin Panella (allenap) wrote :

Originally I prepared this branch to merges James Westby's lp:~james-w/lazr.restful/lazr.restful.fix_test_suite branch into trunk. However, there was a failing test, so it needs another review.

Revision history for this message
Gavin Panella (allenap) wrote :

Just wanted to add that the failing test is not James Westby's fault. It exists in trunk.

Revision history for this message
Guilherme Salgado (salgado) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'setup.py'
--- setup.py 2009-09-01 13:12:20 +0000
+++ setup.py 2009-09-25 13:40:27 +0000
@@ -91,5 +91,5 @@
91 'z3c.recipe.sphinxdoc'],91 'z3c.recipe.sphinxdoc'],
92 xml=['lxml',] # requiring this of normal users is too much92 xml=['lxml',] # requiring this of normal users is too much
93 ),93 ),
94 test_suite='lazr.yourpkg.tests',94 test_suite='lazr.restful.tests',
95 )95 )
9696
=== modified file 'src/lazr/restful/example/base/tests/field.txt'
--- src/lazr/restful/example/base/tests/field.txt 2009-09-24 15:23:48 +0000
+++ src/lazr/restful/example/base/tests/field.txt 2009-09-25 13:40:27 +0000
@@ -56,9 +56,12 @@
56 "http://.../cookbooks/The%20Joy%20of%20Cooking"56 "http://.../cookbooks/The%20Joy%20of%20Cooking"
5757
58 >>> print webservice(link_field_url, 'PATCH', new_value)58 >>> print webservice(link_field_url, 'PATCH', new_value)
5959 HTTP/1.1 209 Content Returned
60 >>> print webservice.get(link_field_url).jsonBody()60 ...
61 http://.../cookbooks/The%20Joy%20of%20Cooking61 Content-Type: application/json
62 ...
63 <BLANKLINE>
64 "http://cookbooks.dev/1.0/cookbooks/The%20Joy%20of%20Cooking"
6265
63The same rules for modifying a field apply whether you're modifying66The same rules for modifying a field apply whether you're modifying
64the entry as a whole or just modifying a single field.67the entry as a whole or just modifying a single field.

Subscribers

People subscribed via source and target branches