Code review comment for lp:~amanica/bzr/rm_dir_with_changed_emigrated_file-129880

Revision history for this message
Marius Kruger (amanica) wrote :

fixed those nits.

I quickly checked the performance and it does not look to degrade too badly (removing 846 files):

bzr revert ; bzr mv bzrlib/export/ export ; time bzr rm `find bzrlib`
== bzr.dev ==
real 0m0.893s
user 0m0.760s
sys 0m0.110s

real 0m0.914s
user 0m0.800s
sys 0m0.100s

real 0m0.902s
user 0m0.800s
sys 0m0.080s

== bzr.dev with my patch ==
real 0m0.900s
user 0m0.800s
sys 0m0.070s

real 0m0.904s
user 0m0.790s
sys 0m0.090s

real 0m0.947s
user 0m0.790s
sys 0m0.110s

« Back to merge proposal