loggerhead

Code review comment for lp:~amanica/loggerhead/loggerheadd

loggerheadd
Merge into trunk-rich

Revision history for this message

Marius Kruger (amanica) wrote on 2008-11-07:

Hi Martin

I'll see what I can do over the weekend.

* I think most of Tim's comments should be easy to resolve.
* WRT what to do in setup.py,
  - I dont think its feasible to install automatically,
    unless we ask a bunch of questions about what is the bzrroot, the port
etc.
    OR if we choose good defaults.
  - the script won't work on anything but linux, so setup should not install
it for non-supported platforms.
  - ATM the config is hardcoded in the script, but I think we can read it
from /etc/loggerhead .

To make it really nice might take some time, so we might settle on just
improving the installation instructions for people who can do it manually.
For this release.

2008/11/7 Martin Albisetti <email address hidden>

> Hi Marius!
> I'm keen to include this in the upcoming release.
> Would you have time to address the concerns in the review?
> --
> https://code.edge.launchpad.net/~amanica/loggerhead/loggerheadd/+merge/1205<https://code.edge.launchpad.net/%7Eamanica/loggerhead/loggerheadd/+merge/1205>
> You are subscribed to branch lp:~amanica/loggerhead/loggerheadd.
>

« Back to merge proposal