Code review comment for lp:~amanica/loggerhead/loggerheadd

2008/10/24 Tim Penhey <email address hidden>

> Is /opt/loggerhead where the packaged loggerhead gets installed by default?

no.
I saw that setup.py puts serve-branches in the path, so by default I now
assume
it is in the path. If the user has it somewhere else he should configure
accordingly.

> Does the directory /var/log/loggerhead get created anywhere? Through very
> rudimentary testing it seems that it should be made in the start call.

oops.
it will now be created when starting loggerhead (if it doesn't exist).

> Also, the default directory that is served seems weird. I'm sure it makes
> sense for you but we should have a more generic location specified in trunk.

:) oops again
I could not think up a safe default so I made it /bzrroot for now, which
should force the user to configure this properly

> I can't verify that the netstat query is valid, but I'm happy if others
> know how it all works.

I improved it a little.

I uploaded my latest changes.

WRT auto installing it using setup.py as I said earlied, I dont think its
feasible to install automatically. Maybe somebody else knows how to do this,
or whether its a good idea or not.

regards
marius