Code review comment for lp:~andrewsomething/xscreensaver/bug-385850

Revision history for this message
Robert Ancell (robert-ancell) wrote :

Looks a lot simpler to me. Some feedback:
- It would be nice to echo something while each hack is being packaged. Currently building with this branch uses a lot of CPU and doesn't provide any feedback as to which hack is being built.
- For readability I'd list the hacks in split-hacks.conf like this:
# Default screensavers
(xscreensaver-data hacks)
(xscreensaver-gl hacks)

# Optional screensavers
(xscreensaver-data-extra hacks)
(xscreensaver-gl-extra hacks)

# Broken screensavers
(xscreensaver-data-extra hacks)
(xscreensaver-gl-extra hacks)

a) Don't know if the current script will handle comments like this
b) This will make it harder to do a simple merge between Debian and Ubuntu but I think this is better than commenting on each one

review: Approve

« Back to merge proposal