Code review comment for lp:~andrewsomething/xscreensaver/bug-385850

> Looks a lot simpler to me. Some feedback:
> - It would be nice to echo something while each hack is being packaged.
> Currently building with this branch uses a lot of CPU and doesn't provide any
> feedback as to which hack is being built.

Thanks for the feedback. Yes, these dh_install scripts are quite resource intensive. They are more efficient when they are called once with a bunch of files and not serialised like now. You could add intermediate steps building up a list of files to install and then call dh_install once but it would add more code and I don't think build efficiency is very important. I don't think more verbosity is needed, because you will see which hack is being packaged if there is an error or warning.

> - For readability I'd list the hacks in split-hacks.conf like this:
> a) Don't know if the current script will handle comments like this
> b) This will make it harder to do a simple merge between Debian and Ubuntu but
> I think this is better than commenting on each one

a) The script will handle comments like this.
b) Yes, this would take us back to moving things around. I prefer having a static table where we just change a parameter. It is clearer for merges and for history. It is in alphabetic order, but you can just run sort -k2 if you want to _see_ them listed per package.