Code review comment for lp:~andrewsomething/xscreensaver/bug-385850
Revision history for this message
| Andrew Starr-Bochicchio (andrewsomething) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
> It would be nice if you filled in a comment in split-hacks.config for those
> hacks that you move to *-extra in Ubuntu. For those hacks which are moved
> because of performance issues, a bug reference is most welcome.
>
> This will make it easier to evaluate these changes and possibly include them
> in Debian as well.
The choices I used for what stayed in the default packages were based on the comments by Alejandra Obregon in Bug #385850. I didn't want to get caught up in bike-shedding so I just went ahead with that list. The only comments made were positive factors about the hacks to keep. Though she did add that some of the ones moved were due to them being on your list of high-CPU usage ones. I could probably figure out which are which by cross referencing myself, but as she's on the canonical-ux team, perhaps she still has her notes and could share them with Robert?
>> b) This will make it harder to do a simple merge between Debian and Ubuntu but
>> I think this is better than commenting on each one
...
> b) Yes, this would take us back to moving things around. I prefer having a static
> table where we just change a parameter. It is clearer for merges and for history.
> It is in alphabetic order, but you can just run sort -k2 if you want to _see_
> them listed per package.
It seems to me that the main point of creating the script was to make doing a simple merge easier. So I deffer to the Debian maintainer... =)