desktopcouch

Code review comment for lp:~apachelogger/desktopcouch/kwallet-support

  1. kwallet-support
  2. Merge into trunk
Revision history for this message
Rodrigo Moya (rodrigo-moya) wrote :

Wouldn't it be easier to use python-keyring? Also, the way the code is written, it will always check for kwallet first and then, whether it found it or not, check again for gnomekeyring:

22 + if ctx.wallet is not None:
...
43 if ctx.keyring is not None:

review: Needs Fixing

« Back to merge proposal