Code review comment for lp:~asac/bzr/lp459276

Alexander,

Thanks for the patch. I'm ok with the concept though I wonder if some other core members might have concerns? It might be worth a short email to the list explaining the problem and outlining your suggested improvement. Others can then provide input as to whether we ought to solve it another way or in the way you've proposed.

The code itself looks fine. Assuming there's agreement on doing this, it really needs some tests though before we can land it. Some other minor things:

* Please add a '.' to the end of the commit-time help to pass our pre-commit checks.
* Please add an entry to NEWS.