Code review comment for lp:~bac/launchpad/bug-422334-contact-team

Revision history for this message
Brad Crittenden (bac) wrote :

= Summary =

Bug 422334 is about the 'Contact team' link being in the team details portlet on
team-index.pt and not in the side action portlet as in person-index.pt.

== Proposed fix ==

Move the contact link to the side. Since the code from person-index.pt needs to be
duplicated in team-index.pt it was turned into a macro in person-macros.pt for re-use.

The new layout can be seen at:
http://people.canonical.com/~bac/bug-422334-contact-team/

== Pre-implementation notes ==

IRC notes from Curtis.

== Implementation details ==

As above.

== Tests ==

None as the link is checked in existing tests but not placement.

== Demo and Q/A ==

Go to a team page and verify the placement.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/registry/templates/team-index.pt
  lib/lp/registry/templates/person-index.pt
  lib/lp/registry/templates/person-macros.pt

« Back to merge proposal