Code review comment for lp:~bac/launchpad/bug-429455-team-pages

= Summary =

Bug 429455 requires the conversion of three team pages to UI 3.0:
team-map.pt
team-mugshots.pt
team-members.pt

== Proposed fix ==

Provide changes to fulfill the new UI requirements.

== Pre-implementation notes ==

N/A

== Implementation details ==

* team-map.pt
  * Convert to main_only.
  * Remove from pagetitles.py
  * Create label property
  * Remove h1
  * Remove the section that displays team members with no location
    data and invites anyone to set it for them - Bug 262193

* team-mugshots.pt
  * Convert to main_only.
  * Remove from pagetitles.py
  * Create label property
  * Remove h1

* team-members.pt

== Tests ==

bin/test -vvm lp.registry -t team-map.txt
     -t stories/mailinglists/moderation.txt

== Demo and Q/A ==

Screenshots are available at
http://people.canonical.com/~bac/bug-429455-team-pages

* As Mark, go to: https://launchpad.dev/~hwdb-team/+map
  * Note page title, label, and breadcrumbs.

* Go to https://launchpad.dev/~hwdb-team/+mugshots
  * Note page title, label, and breadcrumbs.
  * Without the side there is much more real estate for photos.

* Go to https://launchpad.dev/~hwdb-team/+members
  * Note page title, label, and breadcrumbs.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/registry/stories/foaf/xx-team-membership.txt
  lib/canonical/config/schema-lazr.conf
  lib/canonical/launchpad/pagetitles.py
  lib/canonical/launchpad/database/librarian.py
  lib/lp/registry/browser/team.py
  lib/lp/registry/templates/team-mugshots.pt
  lib/lp/registry/templates/team-members.pt
  lib/lp/registry/templates/team-map.pt
  lib/lp/registry/browser/person.py
  lib/lp/registry/stories/location/team-map.txt
  configs/development/launchpad-lazr.conf

== Pylint notices ==

lib/lp/registry/browser/person.py
    119: [F0401] Unable to import 'lazr.delegates' (No module named delegates)
    120: [F0401] Unable to import 'lazr.config' (No module named config)
    121: [F0401] Unable to import 'lazr.restful.interface' (No module named restful)

--
Brad Crittenden
<email address hidden>