Merge lp:~bac/launchpad/bug-432163-join-link into lp:launchpad
Proposed by
Brad Crittenden
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Merged at revision: | not available | ||||||||
Proposed branch: | lp:~bac/launchpad/bug-432163-join-link | ||||||||
Merge into: | lp:launchpad | ||||||||
Diff against target: | None lines | ||||||||
To merge this branch: | bzr merge lp:~bac/launchpad/bug-432163-join-link | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Curtis Hovey (community) | code | Approve | |
Canonical Launchpad Engineering | Pending | ||
Review via email: mp+12064@code.launchpad.net |
To post a comment you must log in.
= Summary =
Bug 432163 notes that the 'Join this team' link is absurdly large and trying to pass
itself off as a download link.
== Proposed fix ==
Remove the hard-coded bits from the page template and add 'join' to the
TeamIndexMenu. It'll then show up in the correct portlet and the conditional logic
will just work.
== Pre-implementation notes ==
None.
== Implementation details ==
As above.
== Tests ==
bin/test -vvm lp.registry -t stories/ teammembership
but for fun I just run all registry tests.
== Demo and Q/A ==
Go to an open membership team you aren't a member. Note the appropriately sized and
located 'Join this team' link. Join the team. Note the link is not present but
'Leave' is.
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files: registry/ templates/ team-index. pt registry/ browser/ person. py
lib/lp/
lib/lp/
== Pylint notices ==
lib/lp/ registry/ browser/ person. py interface' (No module named restful)
117: [F0401] Unable to import 'lazr.delegates' (No module named delegates)
118: [F0401] Unable to import 'lazr.config' (No module named config)
119: [F0401] Unable to import 'lazr.restful.