Code review comment for lp:~bac/launchpad/bug-432163-join-link

= Summary =

Bug 432163 notes that the 'Join this team' link is absurdly large and trying to pass
itself off as a download link.

== Proposed fix ==

Remove the hard-coded bits from the page template and add 'join' to the
TeamIndexMenu. It'll then show up in the correct portlet and the conditional logic
will just work.

== Pre-implementation notes ==

None.

== Implementation details ==

As above.

== Tests ==

bin/test -vvm lp.registry -t stories/teammembership

but for fun I just run all registry tests.

== Demo and Q/A ==

Go to an open membership team you aren't a member. Note the appropriately sized and
located 'Join this team' link. Join the team. Note the link is not present but
'Leave' is.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/registry/templates/team-index.pt
  lib/lp/registry/browser/person.py

== Pylint notices ==

lib/lp/registry/browser/person.py
    117: [F0401] Unable to import 'lazr.delegates' (No module named delegates)
    118: [F0401] Unable to import 'lazr.config' (No module named config)
    119: [F0401] Unable to import 'lazr.restful.interface' (No module named restful)