Code review comment for lp:~bac/launchpad/bug-436259-add-member

Revision history for this message
Brad Crittenden (bac) wrote :

= Summary =

Bug 436259 asked for an '(+) Add member' link on the +members page. While doing that
I noticed another layout problem with overlapping icon and text.

== Proposed fix ==

Add the link. Fix the overlap by using sprites as required.

== Pre-implementation notes ==

None.

== Implementation details ==

As above.

== Tests ==

bin/test -vv -t xx-add-member.txt -t xx-approve-members.txt

== Demo and Q/A ==

Look at http://launchpad.net/~some-team-you-administer

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

« Back to merge proposal