Code review comment for lp:~bac/launchpad/bug-436978-pg-index

Revision history for this message
Brad Crittenden (bac) wrote :

= Summary =

Bug 436978 reports that project group index pages time out.

== Proposed fix ==

The main reason for the time out is collecting information about milestones for
projects that have a lot of them.

Upon review of that page we determined that including series and milestone
information about all projects in a project group does not make sense. That
information is too detailed for that level view.

== Pre-implementation notes ==

Call with Curtis.

== Implementation details ==

Simply remove the series and milestone data from the page template. The list was
then converted from a <dl> to a <ul>.

The menus at the bottom of that section were placed horizontally which caused ugly
wrapping. They have been changed to be vertical and look much better.

== Tests ==

bin/test -vvt xx-project-index.txt

== Demo and Q/A ==

http://launchpad.dev/mozilla
https://edge.launchpad.net/gnome

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/registry/stories/project/xx-project-index.txt
  lib/lp/registry/templates/project-index.pt

« Back to merge proposal