Code review comment for lp:~bac/launchpad/bug-461164-downloadfix

Revision history for this message
Brad Crittenden (bac) wrote :

= Summary =

The +download page was creating extra vertical space. Some class ids were not proper
 CSS as they were not unique and had _ instead of -.

== Proposed fix ==

Re-arranged some of the conditional elements to not generate unnecessary <p> and
other elements. Used fmt:css-id to ensure proper ids.

== Pre-implementation notes ==

Quick chat with Curtis.

== Implementation details ==

As above.

== Tests ==

No tests were changed. I'm running the full registry suite to ensure nothing has
been broken.

== Demo and Q/A ==

Go to https://launchpad.dev/firefox. Create some extra series with no releases.
View https://launchpad.dev/firefox/+download and ensure there is not extra space at
the bottom.

Inspect the generated HTML to ensure there are no invalid CSS elements.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/registry/templates/product-files.pt

« Back to merge proposal