Code review comment for lp:~bac/launchpad/bug-485237

= Summary =

Bug 485237 reports an OOPS that occurs in the rare instance that an
unvalidated person with a preferred email address is viewed by an admin.

== Proposed fix ==

The template was using a broken, hand-crafted link to an image. It has
been replaced by using a proven TALES formatter.

In the process it was noticed that person-portlet-emails was unused and
has been removed.

== Pre-implementation notes ==

None.

== Implementation details ==

As above.

== Tests ==

No view tests existed for this corner case and none have been crafted.

== Demo and Q/A ==

As Mark go to http://launchpad.dev/~nsv. Click on 'Change details' and
enter an email address you control. If your system is set up to
properly send out Launchpad email you'll get a validation email. Click
on the link to confirm. That will take you back to the ~nsv page with
the exact scenario that previously broke. Verify you get no OOPS.

For QA have an admin visit the link provided in the bug.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/registry/browser/configure.zcml
  lib/canonical/launchpad/pagetests/basics/notfound-traversals.txt
  lib/lp/registry/templates/person-index.pt