Code review comment for lp:~bac/launchpad/bug-487965

Revision history for this message
Brad Crittenden (bac) wrote :

= Summary =

Bug 487965 reports an OOPS that occurs when attempting to look at
packages for a product when there are more than one distribution
represented.

== Proposed fix ==

The dictionaries representing the distros and packaging used to have an
entry with the distribution name in it. Since the name was used as the
key for the containing dictionary it, having the name in the distro
dictionary looked redundant and it was inadvertently removed.

While I could've just stuffed it back in I though restructuring the code
to be less fragile was a better solution.

== Pre-implementation notes ==

None.

== Implementation details ==

As above.

== Tests ==

bin/test -vvt packaging-views.txt

== Demo and Q/A ==

Visit the product in the bug report and ensure it doesn't OOPS.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/registry/browser/product.py
  lib/lp/registry/browser/tests/packaging-views.txt

== Pylint notices ==

lib/lp/registry/browser/product.py
    54: [F0401] Unable to import 'lazr.delegates' (No module named
delegates)

« Back to merge proposal