Code review comment for lp:~bac/launchpad/bug-490505

Revision history for this message
Brad Crittenden (bac) wrote :

= Summary =

ValidPersonOrTeamCache was including teams that had been merged and really should not
be considered valid. This patch removes them from the view.

== Proposed fix ==

db patch to redefine the view to not include merged teams.

== Pre-implementation notes ==

None.

== Implementation details ==

As above.

== Tests ==

None.

== Demo and Q/A ==

Demo by merging a team in the UI and then running a query on the view to ensure the
merged team is not there.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  database/schema/patch-2207-99-0.sql

« Back to merge proposal