Code review comment for lp:~bac/launchpad/bug-490505

Revision history for this message
Данило Шеган (danilo) wrote :

There are several concerns:
 * the bug is already targetted at 3.1.13
 * we don't know how this affects DB upgrade timing
 * this doesn't seem that urgent considering how long it's been in the loop
 * and, it's a DB patch which makes stuff much harder for everyone, and would kick off the staging DB restore, thus not having staging pick up code updates every half an hour
 * even if staging restore is done, there's not enough time to QA this

As such, I'd rather see this moved to the next cycle, unless there's a particularly strong reason (i.e. this is critical) to do it now.

I am disapproving for now, but I am open to be convinced otherwise.

review: Disapprove (release-critical)

« Back to merge proposal